Skip to content

Swagger for IoT Hub Routing Storage Endpoints #1488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vishal-gandhi
Copy link
Contributor

@vishal-gandhi vishal-gandhi commented Jul 28, 2017

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@msftclas
Copy link

@vishal-gandhi,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@vishal-gandhi vishal-gandhi changed the title Swagger for Routing Storage Endpoints Swagger for IoT Hub Routing Storage Endpoints Jul 28, 2017
@sarangan12
Copy link
Contributor

@vishal-gandhi This is a new version of the iot service. So, the configuration file needs to be modified to point to the new file https://github.com/Azure/azure-rest-api-specs/tree/current/specification/iothub/resource-manager Please update it

@sarangan12
Copy link
Contributor

@vishrutshah any idea why the bot has not run with the latest commit?

@sarangan12
Copy link
Contributor

@vishal-gandhi Please take a look at https://travis-ci.org/Azure/azure-rest-api-specs/jobs/259554831 There are several errors and warnings (about missing descriptions). Please fix them

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/iothub/resource-manager/readme.md
Before the PR: Warning(s): 40 Error(s): 20
After the PR: Warning(s): 40 Error(s): 18

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

@sarangan12
Copy link
Contributor

@vishal-gandhi There are still errors in the validation. Some of these errors do not need service side changes so they must be fixed. Please fix them

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/iothub/resource-manager/readme.md
Before the PR: Warning(s): 40 Error(s): 20
After the PR: Warning(s): 40 Error(s): 17

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

@sarangan12 sarangan12 merged commit d932de9 into Azure:current Aug 3, 2017
@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-python

@AutorestCI
Copy link

@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-node

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants