PortalSettings resource added to the Azure APIM specification

[promoisha]

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

• [+ ] The title of the PR is clear and informative.
• [+ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
• [+ ] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
• If applicable, the PR references the bug/issue that it fixes.
• [+ ] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

• [+ ] I have read the contribution guidelines.
• My spec meets the review criteria:
  • [+ ] The spec conforms to the Swagger 2.0 specification.
  • [+ ] The spec follows the guidelines described in the Swagger checklist document.
  • [ +] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

[msftclas]

@promoisha,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

[solankisamir]

Add this file to the readme.md under 2017-03-01

[promoisha]

Done.

[alvadb]

Should this key be public?

[promoisha]

Yes, as it's not the actual key, but some hashed value of the URL.

[alvadb]

There are some linter errors (https://travis-ci.org/Azure/azure-rest-api-specs/jobs/275169528). Please fix.

[promoisha]

@alvadb I fixed a bunch of linter warnings and left some minor warnings/errors out of the fix. The error that 'Operations API must be implemented' is not relevant to the resource I'm adding because it's not going to be registered in ARM.

[azuresdkciprbot]

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/apimanagement/resource-manager/readme.md
Before the PR: Warning(s): 69 Error(s): 22
After the PR: Warning(s): 78 Error(s): 22

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

[alvadb]

Most of the errors from the linter appear to be from missing examples but there is one that is a casing issue:
{
"type": "Error",
"code": "DefinitionsPropertiesNamesCamelCase",
"message": "Property named: 'Value', for definition: 'QuotaCounterContract' must follow camelCase style. Example: 'value'.",
"id": "R3016",
"validationCategory": "RPCViolation",
"providerNamespace": null,
"resourceType": null,
"sources": [
"file:///home/travis/build/Azure/azure-rest-api-specs/specification/apimanagement/resource-manager/Microsoft.ApiManagement/2017-03-01/apimquotas.json:284:8 ($.definitions.QuotaCounterContract.properties.Value)"
]
}

Can you fix?

Also, there are a couple of semantic issues and the errors appear to indicate that there are duplicate paths. Please check: https://travis-ci.org/Azure/azure-rest-api-specs/jobs/276094929.

[promoisha]

@alvadb We'll create a separate task for the error you mentioned, just to keep the current PR clean and to not block it with unrelated fixes. Regarding semantics, waiting for the response from @veronicagg.

[veronicagg]

@promoisha I've replied on the related issue, thanks.

[promoisha]

@alvadb I changed the code in order to put the enum values directly in the path, as per https://github.com/Azure/azure-rest-api-specs/issues/1678#issuecomment-331509672. There should be no issues with the portalsettings spec by now. Thanks.

[azuresdkciprbot]

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/apimanagement/resource-manager/readme.md
Before the PR: Warning(s): 69 Error(s): 22
After the PR: Warning(s): 78 Error(s): 22

💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

[alvadb]

Will merge with the linter errors since they will be address in a subsequent check in.

[AutorestCI]

No modification for AutorestCI/azure-sdk-for-node

[AutorestCI]

No modification for AutorestCI/azure-sdk-for-python

[AutorestCI]

No modification for AutorestCI/azure-sdk-for-ruby