-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Adding new resource types for RecourceNotifications #36086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Created Microsoft.ResourceNotifications.Management TypeSpec project - Added main.tsp with service definition and API versioning - Added models.tsp with ResourceNotification resource model and CRUD operations - Added tspconfig.yaml with compilation and linting configuration - Includes notification severity levels (Information, Warning, Error, Critical) - Includes notification status tracking (Active, Acknowledged, Resolved, Expired) - Follows Azure Resource Manager patterns with tracked resources
- Added NotificationSession resource model with properties: - creationTime (read-only) - lastUsedTime (read-only) - provisioningState (read-only) - Added ProvisioningState union with ARM standard states - Added CRUD operations for NotificationSession: - GET /providers/Microsoft.ResourceNotifications/locations/{location}/notificationSessions/{name} - PUT /providers/Microsoft.ResourceNotifications/locations/{location}/notificationSessions/{name} - DELETE /providers/Microsoft.ResourceNotifications/locations/{location}/notificationSessions/{name} - GET /providers/Microsoft.ResourceNotifications/locations/{location}/notificationSessions - Includes async provisioning support (202 Accepted responses) - Follows ARM patterns for error handling and responses - TypeSpec compiles with warnings but generates OpenAPI structure
- Created ResourceNotifications service with API version 2024-12-01-preview - Added ResourceNotification resource with notification properties and CRUD operations - Added NotificationSession resource with async provisioning support - Generated OpenAPI specification with ARM compliance - Includes proper ARM resource patterns and long-running operation support
Next Steps to MergeNext steps that must be taken to merge this PR:
|
PR validation pipeline started successfully. If there is ApiView generated, it will be updated in this comment. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
@Priyanarang please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
1 similar comment
@Priyanarang please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
@useDependency(Azure.ResourceManager.Versions.v1_0_Preview_1) | ||
@useDependency(Azure.Core.Versions.v1_0_Preview_1) | ||
@armCommonTypesVersion(Azure.ResourceManager.CommonTypes.Versions.v5) | ||
v2024_12_01_preview: "2024-12-01-preview", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update version to something recent, such as 2025-08-01-preview
@@ -0,0 +1,181 @@ | |||
import "@azure-tools/typespec-azure-core"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this tsp file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this file and directory
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.
Click here to open a PR for only SDK configuration.