[LintDiff] Report generator shows when "before" state has errors #36126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljurek
requested review from
weshaggard,
mikeharder and
benbp
as code owners
Next Steps to MergeNext steps that must be taken to merge this PR:
|
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
openapi-pipeline-app
bot
added
PipelineBotTrigger
and removed
PipelineBotTrigger
labels
mikeharder
approved these changes
Jul 23, 2025
|
Bypassing rules to merge. This PR intends to update protected files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36082
Example PR with swagger changes and autorest failing in the
beforestate. In this case the table notes "Autorest failed" and there's a warning. Since there are no prior violations to compare (because of the autorest failure) all violations in theafterstate are treated as "new":https://github.com/Azure/azure-rest-api-specs/actions/runs/16475273232
Example PR with fixes to
readme.md. In this case, the PR did not change any swagger files. LintDiff only surfaces errors for affected swaggers which, when no swagger files are edited, is an empty set.https://github.com/Azure/azure-rest-api-specs/actions/runs/16475290346?pr=36137