-
Notifications
You must be signed in to change notification settings - Fork 2.1k
servicebus jms autoconfiguration enabled fix #29313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jialigit
merged 6 commits into
Azure:main
from
jialigit:fix-servicebus-jms-properties-autoconfiguration
Jun 13, 2022
Merged
servicebus jms autoconfiguration enabled fix #29313
jialigit
merged 6 commits into
Azure:main
from
jialigit:fix-servicebus-jms-properties-autoconfiguration
Jun 13, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API change check APIView has identified API level changes in this PR and created following API reviews. |
…properties-autoconfiguration # Conflicts: # sdk/spring/CHANGELOG.md
saragluna
requested changes
Jun 8, 2022
...e/src/main/java/com/azure/spring/cloud/autoconfigure/jms/ServiceBusJmsAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...n/java/com/azure/spring/cloud/autoconfigure/jms/properties/AzureServiceBusJmsProperties.java
Outdated
Show resolved
Hide resolved
@saragluna we have a change in the autoconfiguration which bring error in revapi check. This may lead the ci fail. |
@jialigit we're okay to suppress such changes in revapi |
@saragluna , we ignore the difference in the revapi.json: {
"code": "java.annotation.added",
"new": "class com.azure.spring.cloud.autoconfigure.jms.ServiceBusJmsAutoConfiguration",
"justification": "Fixes a bug."
} |
saragluna
approved these changes
Jun 13, 2022
3 tasks
khmic5
pushed a commit
to daniel-rocha/azure-sdk-for-java
that referenced
this pull request
Jun 19, 2022
* servicebus jms autoconfiguration enabled option fix * servicebus jms autoconfiguration enabled add changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solves #29232
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines