Skip to content

servicebus jms autoconfiguration enabled fix #29313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jialigit
Copy link
Contributor

@jialigit jialigit commented Jun 8, 2022

Description

Solves #29232

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added the azure-spring All azure-spring related issues label Jun 8, 2022
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

spring-cloud-azure-autoconfigure

…properties-autoconfiguration

# Conflicts:
#	sdk/spring/CHANGELOG.md
@jialigit jialigit marked this pull request as ready for review June 8, 2022 12:30
@saragluna saragluna added this to the [2022] July milestone Jun 8, 2022
@jialigit
Copy link
Contributor Author

jialigit commented Jun 9, 2022

@saragluna we have a change in the autoconfiguration which bring error in revapi check. This may lead the ci fail.

@saragluna
Copy link
Member

@jialigit we're okay to suppress such changes in revapi

@jialigit
Copy link
Contributor Author

@saragluna , we ignore the difference in the revapi.json:
adding the following rule for service bus jms autoconfiguration.

   {
          "code": "java.annotation.added",
          "new": "class com.azure.spring.cloud.autoconfigure.jms.ServiceBusJmsAutoConfiguration",
          "justification": "Fixes a bug."
        }

@jialigit jialigit merged commit e9cce37 into Azure:main Jun 13, 2022
khmic5 pushed a commit to daniel-rocha/azure-sdk-for-java that referenced this pull request Jun 19, 2022
* servicebus jms autoconfiguration enabled option fix

* servicebus jms autoconfiguration enabled  add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants