-
Notifications
You must be signed in to change notification settings - Fork 2.1k
OpenTelemetry Metrics Support For Live Metrics #41220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…kumar/azure-sdk-for-java into t-nsukumar/experimentation
Resolving Merge Conflicts
… t-nsukumar/experimentation
…kumar/azure-sdk-for-java into t-nsukumar/experimentation
…kumar/azure-sdk-for-java into t-nsukumar/experimentation
.../azure/monitor/opentelemetry/exporter/implementation/quickpulse/QuickPulseDataCollector.java
Outdated
Show resolved
Hide resolved
public void run() { | ||
while (true) { | ||
|
||
Collection<MetricData> metrics = quickPulseMetricReader.collectAllMetrics(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an expensive operation - may want to introduce 1s delay when going from off to on so we're not reading the last timeframe of metrics.
Hi @navsukumar. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
Valuable change, hope it will be rejuvenated. |
Hi @navsukumar. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing |
To continue work here in a different fork: #43564 |
Summary: This PR enables Open Telemetry metrics to be streamed and seen on the Live Metrics UX. Includes functionality to collect, store, and send requested open telemetry metrics.
QuickPulseConfiguration:
QuickPulseCollector:
QuickPulseDataFetcher:
QuickPulseDataSender:
QuickPulsePingSender:
QuickPulseMetricReader.
QuickPulseMetricReceiver.