Skip to content

Conversation

@balalakshmin
Copy link
Member

@balalakshmin balalakshmin commented Jul 4, 2023

Packages impacted by this PR

@azure/cosmos

Issues associated with this PR

Describe the problem that is addressed by this PR

This PR adds PriorityLevel to Request options and passes it as header to the backend. This header is used to set priority to requests and throttle low priority requests before high priority requests are throttled.

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Yes

Provide a list of related PRs (if any)

Corresponding .Net PR
Corresponding Java PR

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

Copy link
Member

@topshot99 topshot99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments

@topshot99
Copy link
Member

@balalakshmin Could you kindly initiate a package build using 'rushx build' and subsequently upload the resulting 'api.md' file? Additionally, could you please check ESlint errors? Once this is completed, we can proceed with the merge.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-cosmos

@balalakshmin balalakshmin merged commit 2dfe32b into main Sep 5, 2023
dgetu pushed a commit that referenced this pull request Sep 6, 2023
### Packages impacted by this PR
@azure/cosmos

### Issues associated with this PR


### Describe the problem that is addressed by this PR
This PR adds PriorityLevel to Request options and passes it as header to
the backend. This header is used to set priority to requests and
throttle low priority requests before high priority requests are
throttled.

### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_
Yes

### Provide a list of related PRs _(if any)_
Corresponding [.Net
PR](Azure/azure-cosmos-dotnet-v3#3672)
Corresponding [Java
PR](Azure/azure-sdk-for-java#34121)

### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [x] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants