Skip to content

[instrumentation] Fix snippets imports for named imports #33891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025

Conversation

mpodwysocki
Copy link
Contributor

Packages impacted by this PR

  • @azure/opentelemetry-instrumentation-azure-sdk

Issues associated with this PR

Describe the problem that is addressed by this PR

Fixes the snippets extraction by using explicit imports instead of default imports.

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@Copilot Copilot AI review requested due to automatic review settings April 17, 2025 03:12
@mpodwysocki mpodwysocki requested a review from maorleger as a code owner April 17, 2025 03:12
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@mpodwysocki mpodwysocki merged commit 85702c8 into main Apr 17, 2025
18 checks passed
@mpodwysocki mpodwysocki deleted the feat/instrumentation-snippets-fix branch April 17, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants