Skip to content

[Core] Don't check in a bunch of commented code into the main branch #29035

Closed
@jzabroski

Description

@jzabroski

API Change Needed

No

Background and motivation

I found a GitHub comment by Eric Sampson (Microsoft) suggesting we go look at how the Azure SDK implemented support for robust HttpClient usage. So, I checked out ServiceClient.cs and found over 40 lines of commented out code.

API / Feature Proposal

Can someone clean this up and address it?

https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/mgmtcommon/ClientRuntime/ClientRuntime/ServiceClient.cs

Time Constraints and Dependencies

The dependency would be that another Microsoft team claims this is a gold standard reference implementation, and it does not look like any production code I would use.

dotnet/aspnetcore#28385 (comment)

Stakeholders

@shahabhijeet

Metadata

Metadata

Assignees

Labels

Azure.CoreMgmtThis issue is related to a management package.customer-reportedIssues that are reported by GitHub users external to the Azure organization.needs-team-attentionWorkflow: This issue needs attention from Azure service team or SDK teamquestionThe issue doesn't require a change to the product in order to be resolved. Most issues start as that

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions