Removing default usage of deprecating 2014-04-01 SQL APIs #50381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Update SQL management SDK to use the latest stable API version (2023-08-01) instead of the deprecated 2014-04-01 across resource clients, collections, and REST operations.
- Bumped default API version strings in XML doc comments and default constructor parameters
- Ensured consistency across all
Customresource, collection, and rest operation classes
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| SqlServerResource.cs | Updated XML <description> version tag to 2023-08-01 |
| SqlServerCommunicationLinkResource.cs | Updated XML <description> version tag to 2023-08-01 |
| SqlServerCommunicationLinkCollection.cs | Updated XML <description> version tag to 2023-08-01 |
| SqlDatabaseResource.cs | Updated XML <description> version tag to 2023-08-01 |
| ServiceObjectiveResource.cs | Updated XML <description> version tag to 2023-08-01 |
| ServiceObjectiveCollection.cs | Updated XML <description> version tag to 2023-08-01 |
| ServiceObjectivesRestOperations.cs | Bumped default _apiVersion to 2023-08-01 |
| ServerCommunicationLinksRestOperations.cs | Bumped default _apiVersion to 2023-08-01 |
| MetricsRestOperations.cs | Bumped default _apiVersion to 2023-08-01 |
| MetricDefinitionsRestOperations.cs | Bumped default _apiVersion to 2023-08-01 |
| ElasticPoolDatabaseActivitiesRestOperations.cs | Bumped default _apiVersion to 2023-08-01 |
| ElasticPoolActivitiesRestOperations.cs | Bumped default _apiVersion to 2023-08-01 |
| ElasticPoolResource.cs | Updated XML <description> version tag to 2023-08-01 |
| DataMaskingPolicyResource.cs | Updated XML <description> version tag to 2023-08-01 |
github-actions
bot
added
the
Mgmt
ArthurMa1978
reviewed
Jun 4, 2025
| /// </summary> | ||
| /// <param name="cancellationToken"> The cancellation token to use. </param> | ||
| /// <returns> An async collection of <see cref="ElasticPoolActivity"/> that may take multiple service requests to iterate over. </returns> | ||
| public virtual AsyncPageable<ElasticPoolActivity> GetElasticPoolActivitiesAsync(CancellationToken cancellationToken = default) |
There was a problem hiding this comment.
Please retain all public members, but mark them as obsolete.
There was a problem hiding this comment.
Run 'eng\scripts\Export-API.ps1 sqlmanagement' after mark it as obsolete.
ArthurMa1978
reviewed
Jun 4, 2025
| /// <returns> An async collection of <see cref="ElasticPoolActivity"/> that may take multiple service requests to iterate over. </returns> | ||
| public virtual AsyncPageable<ElasticPoolActivity> GetElasticPoolActivitiesAsync(CancellationToken cancellationToken = default) | ||
| { | ||
| HttpMessage FirstPageRequest(int? pageSizeHint) => _elasticPoolActivitiesRestClient.CreateListByElasticPoolRequest(Id.SubscriptionId, Id.ResourceGroupName, Id.Parent.Name, Id.Name); |
There was a problem hiding this comment.
Throw NotSupportedException here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing default usage of deprecating 2014-04-01 SQL APIs. Updating to latest stable version of 2023-08-01. Additionally updating relevant comments.