Fix NullReferenceException when evaluating `RunStepDetailsUpdate.FunctionName #50382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crickman
requested review from
trangevi,
dargilco,
jhakulin,
glharper and
nick863
as code owners
github-actions
bot
added
AI Model Inference
AI Projects
Community Contribution
|
Thank you for your contribution @crickman! We will review the pull request and get back to you soon. |
| @@ -46,7 +46,7 @@ public IReadOnlyList<RunStepDeltaCodeInterpreterOutput> CodeInterpreterOutputs | |||
| => _asCodeCall?.CodeInterpreter?.Outputs; | |||
|
|
|||
| /// <inheritdoc cref="RunStepDeltaFunction.Name"/> | |||
| public string FunctionName => _asFunctionCall.Function?.Name; | |||
| public string FunctionName => _asFunctionCall?.Function?.Name; | |||
There was a problem hiding this comment.
The FunctionName property now returns null when _asFunctionCall is null, but its return type is declared as non-nullable string. Consider changing the return type to string? to accurately reflect nullability or provide a default value with the null-coalescing operator (e.g., ?? string.Empty).
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
This is true for all properties in this class (see FunctionArguments). Project is not setting <Nullable>true</Nullable>. Best to match the current convention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_asFunctionCallmay be null for a non-function related tool. All other properties support null fall-through.Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.