ManagedIdentityCredential throws CUE when endpoint unavailable #50458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christothes
requested review from
KarishmaGhiya,
chlowell,
g2vinay,
maorleger,
minhanh-phan,
pvaneck and
scottaddie
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that when the IMDS endpoint times out, ManagedIdentityCredential surfaces a CredentialUnavailableException instead of propagating an MSAL error. Key changes include:
- Added a non-parallelizable test (
ThrowsCredentialUnavailableWhenIMDSTimesOut) to verify timeout mapping. - Wrapped the MSAL call in
ManagedIdentityClientwith a catch for timeouts and introducedHasInnerExceptionMatching. - Updated the changelog to document the fix.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| sdk/identity/Azure.Identity/tests/ManagedIdentityCredentialTests.cs | Added a test to simulate an IMDS timeout and assert CredentialUnavailableException is thrown. |
| sdk/identity/Azure.Identity/src/ManagedIdentityClient.cs | Added try/catch around MSAL calls to translate timeout errors and introduced a helper method. |
| sdk/identity/Azure.Identity/CHANGELOG.md | Documented the bug fix in the changelog. |
Co-authored-by: Copilot <[email protected]>
JonathanCrd
approved these changes
Jun 5, 2025
…s-CUE-on-endpoint-unavailable
…thub.com:christothes/azure-sdk-for-net into chriss/MiCred-throws-CUE-on-endpoint-unavailable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #47057