[Storage] Blob Typing Final Revision #35606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial decouple check CI * Add helpers from sync to async * Big move to the helper * Fix async import * Fix from_blob_url, Pylint fixes, calls from container_client * Fix test failureS * More lint * Final lint * Move _format_url out to helpers * Pylint * PR feedback, no schema passing, encryption options bag * Lint + missing _ * Fix encryption options bag not reflective of true values * Add missing encryption method check * PR feedback * line-too-long * Fix parenthesis
* Draft 1 * Typo * Give async from_connection_string
* Decouple container_client * Pylint * Build generated client seperately (sync vs. async generated class) * Fix passing blobs for batch * Lint again. * PR feedback * Move out unsupported encryption to encryption file * Add back in blob_client helper for generic_delete_blob_options * Fix parenthesis * Fix too many args by not naming
…py`, `_download.py`) (#33613)
…er.py` and `_shared_access_signature.py` and `_list_blob_helpers.py` (#33628)
* First draft * Fix import * Fix isinstance BlobProperties logic * Fix empty AsyncIterator returning sync iterator * Linter
* Fix blob samples typing * Lint * Fix indent
vincenttran-msft
requested review from
annatisch,
jalauzon-msft and
weirongw23-msft
as code owners
vincenttran-msft
added
Do Not Merge
Storage
|
/azp run python - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jalauzon-msft
approved these changes
Jun 26, 2024
|
/azp run python - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - storage - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vincenttran-msft
commented
Nov 7, 2024
Comment on lines
-200
to
-204
| def _format_url(self, hostname): | ||
| container_name = self.container_name | ||
| if isinstance(container_name, str): | ||
| container_name = container_name.encode('UTF-8') | ||
| return f"{self.scheme}://{hostname}/{quote(container_name)}/{quote(self.blob_name, safe='~/')}{self._query_str}" |
There was a problem hiding this comment.
Original implementation here
Only difference when moved to helper, we don't have access to self.blob_name or self.scheme, so we must pass it in.
l0lawrence
pushed a commit
to l0lawrence/azure-sdk-for-python
that referenced
this pull request
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets out to accomplish the following:
Check for passing livetest
Address any hanging local MyPy errors
Address any hanging requests
This PR should serve as the final verification step before getting APIView approval and moving towards a release 😄
Resolves #32847