move xml dependencies to storage & add AzureStorageError #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MindFlavor
approved these changes
May 16, 2021
Contributor
MindFlavor
left a comment
MindFlavor
left a comment
There was a problem hiding this comment.
Nice work, very neat. 👍
I just have one question about module visibility (but we can address it in another PR if you like).
sdk/storage/src/core/mod.rs
Outdated
| use azure_core::headers::*; | ||
| pub use copy_id::{copy_id_from_headers, CopyId}; | ||
| pub use copy_progress::CopyProgress; | ||
| pub mod parsing_xml; |
Contributor
There was a problem hiding this comment.
I like the idea to move the XML helper functions to a separate module.
Does it need to be public?
Contributor
Author
There was a problem hiding this comment.
It no longer needs to be. I'll make it pub(crate) for this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes two XML dependencies for azure_core, separates out a
parsing_xmlmodulesparsingand moves it to azure_storage. Based on #170 , it starts anAzureStorageError. Errors inazure_storageare switched that error.quick-erroris removed in favor ofthiserror, like #249.