Skip to content

Sync eng/common directory with azure-sdk-tools for PR 15388#4321

Merged
scbedd merged 3 commits into
mainfrom
sync-eng/common-backwards-compatible-pr-creation-15388
May 1, 2026
Merged

Sync eng/common directory with azure-sdk-tools for PR 15388#4321
scbedd merged 3 commits into
mainfrom
sync-eng/common-backwards-compatible-pr-creation-15388

Conversation

@azure-sdk
Copy link
Copy Markdown
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#15388 See eng/common workflow

scbedd and others added 3 commits April 30, 2026 18:23
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…on for the new builds, but other than that, no impact
Copilot AI review requested due to automatic review settings April 30, 2026 18:48
@azure-sdk azure-sdk requested a review from a team as a code owner April 30, 2026 18:48
@azure-sdk azure-sdk requested a review from scbedd April 30, 2026 18:48
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Apr 30, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Syncs eng/common pipeline step templates with azure-sdk-tools PR 15388 by introducing an AuthToken parameter and enabling GitHub App token auto-login for GitHub operations (push, PR creation, release tagging).

Changes:

  • Add AuthToken parameters and conditional login-to-github.yml usage when AuthToken: ''.
  • Switch GitHub token usage to prefer AuthToken and fall back to $(GH_TOKEN) (minted by login).
  • Update git push remote URL to use the x-access-token: format.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
eng/common/pipelines/templates/steps/git-push-changes.yml Adds AuthToken support + optional GitHub App login; updates token usage for rate-limit metrics and push URL.
eng/common/pipelines/templates/steps/create-tags-and-git-release.yml Adds AuthToken support + optional GitHub App login; uses coalesced token for GH_TOKEN.
eng/common/pipelines/templates/steps/create-pull-request.yml Adds AuthToken/PushAuthToken parameters + optional GitHub App login; routes token into push + PR creation steps.

Comment thread eng/common/pipelines/templates/steps/git-push-changes.yml
Comment thread eng/common/pipelines/templates/steps/git-push-changes.yml
Comment thread eng/common/pipelines/templates/steps/create-pull-request.yml
Comment thread eng/common/pipelines/templates/steps/create-pull-request.yml
@scbedd scbedd merged commit d105b86 into main May 1, 2026
21 checks passed
@scbedd scbedd deleted the sync-eng/common-backwards-compatible-pr-creation-15388 branch May 1, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants