Skip to content

Remove namespace from ResourceReference #1995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

matthchr
Copy link
Member

As per kubernetes/community#5455, it is not a recommended pattern.

@matthchr matthchr added this to the codegen-alpha-4 milestone Nov 23, 2021
@matthchr matthchr force-pushed the feature/remove-cross-namespace-refs branch from d4d5f30 to 7ea913a Compare November 23, 2021 01:58
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2021

Codecov Report

Merging #1995 (bffa059) into main (65ccb0f) will increase coverage by 0.00%.
The diff coverage is 53.77%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1995   +/-   ##
=======================================
  Coverage   56.84%   56.84%           
=======================================
  Files         425      425           
  Lines       86265    86176   -89     
=======================================
- Hits        49034    48991   -43     
+ Misses      31172    31122   -50     
- Partials     6059     6063    +4     
Impacted Files Coverage Δ
...ha1api20200801preview/role_assignment_types_gen.go 51.87% <0.00%> (+0.12%) ⬆️
...lpha1api20210101storage/batch_account_types_gen.go 10.34% <0.00%> (+0.17%) ⬆️
.../api/compute/v1alpha1api20200930/disk_types_gen.go 48.19% <0.00%> (+0.05%) ⬆️
...api20201201/virtual_machine_scale_set_types_gen.go 54.83% <0.00%> (+<0.01%) ⬆️
...e/v1alpha1api20201201/virtual_machine_types_gen.go 51.28% <0.00%> (+<0.01%) ⬆️
...e/v1alpha1api20210501/managed_cluster_types_gen.go 51.82% <0.00%> (+<0.01%) ⬆️
...i20210501/managed_clusters_agent_pool_types_gen.go 50.30% <0.00%> (+0.02%) ⬆️
...l/v1alpha1api20210501/flexible_server_types_gen.go 58.50% <0.00%> (+0.04%) ⬆️
...api20210501/flexible_servers_database_types_gen.go 46.44% <0.00%> (+1.03%) ⬆️
...210501/flexible_servers_firewall_rule_types_gen.go 49.04% <0.00%> (+0.15%) ⬆️
... and 110 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65ccb0f...bffa059. Read the comment docs.

@matthchr
Copy link
Member Author

/ok-to-test sha=7ea913a

@matthchr matthchr force-pushed the feature/remove-cross-namespace-refs branch 2 times, most recently from 59538c5 to dc3adf5 Compare November 23, 2021 21:56
@matthchr
Copy link
Member Author

/ok-to-test sha=dc3adf5

Copy link
Contributor

@babbageclunk babbageclunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

As per kubernetes/community#5455, it is not
a recommended pattern.
@matthchr matthchr force-pushed the feature/remove-cross-namespace-refs branch from dc3adf5 to bffa059 Compare November 24, 2021 22:53
@matthchr
Copy link
Member Author

/ok-to-test sha=bffa059

@matthchr matthchr merged commit 9b3b554 into Azure:main Nov 24, 2021
@matthchr matthchr deleted the feature/remove-cross-namespace-refs branch November 24, 2021 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants