-
Notifications
You must be signed in to change notification settings - Fork 217
Remove namespace from ResourceReference #1995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove namespace from ResourceReference #1995
Conversation
d4d5f30
to
7ea913a
Compare
Codecov Report
@@ Coverage Diff @@
## main #1995 +/- ##
=======================================
Coverage 56.84% 56.84%
=======================================
Files 425 425
Lines 86265 86176 -89
=======================================
- Hits 49034 48991 -43
+ Misses 31172 31122 -50
- Partials 6059 6063 +4
Continue to review full report at Codecov.
|
/ok-to-test sha=7ea913a |
59538c5
to
dc3adf5
Compare
/ok-to-test sha=dc3adf5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
v2/tools/generator/internal/interfaces/kubernetes_resource_interface.go
Outdated
Show resolved
Hide resolved
As per kubernetes/community#5455, it is not a recommended pattern.
dc3adf5
to
bffa059
Compare
/ok-to-test sha=bffa059 |
As per kubernetes/community#5455, it is not a recommended pattern.