Skip to content
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/update-wiki-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
mkdir -p output
go build -o output/azcopy
cd output
./azcopy doc
./azcopy doc --format wiki
cd doc
sed -i 's/\.md//' *

Expand Down
26 changes: 21 additions & 5 deletions cmd/doc.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import (

var docCmdInput = struct {
outputLocation string
format string
}{}

// docCmd represents the doc command
Expand All @@ -51,11 +52,24 @@ var docCmd = &cobra.Command{
glcm.Error("The output location is invalid as it is pointing to a file.")
}

// dump the entire command tree's doc into the folder
// it will include this command too, which is intended
err = doc.GenMarkdownTree(rootCmd, docCmdInput.outputLocation)
if err != nil {
glcm.Error(fmt.Sprintf("Cannot generate doc due to error %s, please contact the dev team.", err))
switch docCmdInput.format {
case "wiki":
// Generate GitHub Wiki style documentation
generator := NewWikiGenerator(docCmdInput.outputLocation)
err = generator.Generate(rootCmd)
if err != nil {
glcm.Error(fmt.Sprintf("Cannot generate wiki doc due to error %s, please contact the dev team.", err))
}
glcm.Info(fmt.Sprintf("GitHub Wiki documentation generated in: %s", docCmdInput.outputLocation))
case "default":
fallthrough
default:
// dump the entire command tree's doc into the folder
// it will include this command too, which is intended
err = doc.GenMarkdownTree(rootCmd, docCmdInput.outputLocation)
if err != nil {
glcm.Error(fmt.Sprintf("Cannot generate doc due to error %s, please contact the dev team.", err))
}
}
},
}
Expand All @@ -64,4 +78,6 @@ func init() {
rootCmd.AddCommand(docCmd)
docCmd.PersistentFlags().StringVar(&docCmdInput.outputLocation, "output-location", "./doc",
"where to put the generated markdown files")
docCmd.PersistentFlags().StringVar(&docCmdInput.format, "format", "default",
"output format: 'default' (cobra standard) or 'wiki' (GitHub Wiki style with tables)")
}
258 changes: 258 additions & 0 deletions cmd/docWiki.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,258 @@
// Copyright © Microsoft <[email protected]>
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.

package cmd

import (
"bytes"
"fmt"
"os"
"path/filepath"
"strings"
"text/template"

"github.com/spf13/cobra"
"github.com/spf13/pflag"
)

// WikiGenerator generates GitHub Wiki style documentation
type WikiGenerator struct {
OutputDir string
commands []*cobra.Command
}

// FlagInfo holds information about a command flag for templating
type FlagInfo struct {
Name string
Shorthand string
Type string
DefaultValue string
Description string
}

// CommandInfo holds information about a command for templating
type CommandInfo struct {
Name string
FullName string
Short string
Long string
UseLine string
Example string
LocalFlags []FlagInfo
InheritedFlags []FlagInfo
SubCommands []CommandInfo
ParentName string
HasLocalFlags bool
HasInheritedFlags bool
HasExample bool
HasSubCommands bool
}

// NewWikiGenerator creates a new WikiGenerator
func NewWikiGenerator(outputDir string) *WikiGenerator {
return &WikiGenerator{
OutputDir: outputDir,
commands: make([]*cobra.Command, 0),
}
}

// Generate generates wiki documentation for the given command and its children
func (g *WikiGenerator) Generate(cmd *cobra.Command) error {
// Collect all commands
g.collectCommands(cmd)

// Generate individual command pages (root command becomes azcopy.md)
for _, c := range g.commands {
if err := g.generateCommandPage(c); err != nil {
return fmt.Errorf("failed to generate page for %s: %w", c.Name(), err)
}
}

return nil
}

func (g *WikiGenerator) collectCommands(cmd *cobra.Command) {
g.commands = append(g.commands, cmd)
for _, c := range cmd.Commands() {
if !c.Hidden {
g.collectCommands(c)
}
}
}

func (g *WikiGenerator) getCommandInfo(cmd *cobra.Command) CommandInfo {
info := CommandInfo{
Name: cmd.Name(),
FullName: cmd.CommandPath(),
Short: cmd.Short,
Long: cmd.Long,
UseLine: cmd.UseLine(),
Example: cmd.Example,
}

// Get local flags
cmd.LocalFlags().VisitAll(func(f *pflag.Flag) {
if f.Hidden {
return
}
info.LocalFlags = append(info.LocalFlags, FlagInfo{
Name: f.Name,
Shorthand: f.Shorthand,
Type: f.Value.Type(),
DefaultValue: f.DefValue,
Description: cleanDescription(f.Usage),
})
})

// Get inherited flags
cmd.InheritedFlags().VisitAll(func(f *pflag.Flag) {
if f.Hidden {
return
}
info.InheritedFlags = append(info.InheritedFlags, FlagInfo{
Name: f.Name,
Shorthand: f.Shorthand,
Type: f.Value.Type(),
DefaultValue: f.DefValue,
Description: cleanDescription(f.Usage),
})
})

// Get subcommands
for _, c := range cmd.Commands() {
if !c.Hidden {
info.SubCommands = append(info.SubCommands, CommandInfo{
Name: c.Name(),
FullName: c.CommandPath(),
Short: c.Short,
})
}
}

// Set parent name
if cmd.HasParent() {
info.ParentName = cmd.Parent().CommandPath()
}

// Set boolean helpers
info.HasLocalFlags = len(info.LocalFlags) > 0
info.HasInheritedFlags = len(info.InheritedFlags) > 0
info.HasExample = len(info.Example) > 0
info.HasSubCommands = len(info.SubCommands) > 0

return info
}

func cleanDescription(s string) string {
// Replace newlines with spaces and trim
s = strings.ReplaceAll(s, "\n", " ")
s = strings.ReplaceAll(s, "\t", " ")
// Remove multiple spaces
for strings.Contains(s, " ") {
s = strings.ReplaceAll(s, " ", " ")
}
// Escape pipe characters for markdown tables
s = strings.ReplaceAll(s, "|", "\\|")
return strings.TrimSpace(s)
}

func commandToWikiFilename(cmd *cobra.Command) string {
// Convert "azcopy copy" to "azcopy_copy" (same format as cobra default)
return strings.ReplaceAll(cmd.CommandPath(), " ", "_")
}

func (g *WikiGenerator) generateCommandPage(cmd *cobra.Command) error {
info := g.getCommandInfo(cmd)

tmpl, err := template.New("command").Funcs(template.FuncMap{
"wikiLink": func(fullName string) string {
return strings.ReplaceAll(fullName, " ", "_")
},
"flagName": func(f FlagInfo) string {
if f.Shorthand != "" {
return fmt.Sprintf("`-%s`, `--%s`", f.Shorthand, f.Name)
}
return fmt.Sprintf("`--%s`", f.Name)
},
}).Parse(commandTemplate)
if err != nil {
return err
}

var buf bytes.Buffer
if err := tmpl.Execute(&buf, info); err != nil {
return err
}

filename := filepath.Join(g.OutputDir, commandToWikiFilename(cmd)+".md")
return os.WriteFile(filename, buf.Bytes(), 0644)
Copy link

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File permissions 0644 allow world-readable access. Consider using 0600 or 0640 to restrict read access to owner/group only, especially since these files may be written to arbitrary locations specified by user input.

Suggested change
return os.WriteFile(filename, buf.Bytes(), 0644)
return os.WriteFile(filename, buf.Bytes(), 0600)

Copilot uses AI. Check for mistakes.
}

// Templates

const commandTemplate = `# {{ .FullName }}
{{ .Short }}
## Synopsis
{{ .Long }}
## Usage
` + "```" + `bash
{{ .UseLine }}
` + "```" + `
{{ if .HasExample }}
## Examples
` + "```" + `bash
{{ .Example }}
` + "```" + `
{{ end }}
{{ if .HasLocalFlags }}
## Options
| Flag | Type | Default | Description |
|------|------|---------|-------------|
{{ range .LocalFlags }}| {{ flagName . }} | {{ .Type }} | ` + "`{{ .DefaultValue }}`" + ` | {{ .Description }} |
{{ end }}{{ end }}
{{ if .HasInheritedFlags }}
## Global Options
These options are inherited from parent commands.
| Flag | Type | Default | Description |
|------|------|---------|-------------|
{{ range .InheritedFlags }}| {{ flagName . }} | {{ .Type }} | ` + "`{{ .DefaultValue }}`" + ` | {{ .Description }} |
{{ end }}{{ end }}
{{ if .HasSubCommands }}
## Subcommands
| Command | Description |
|---------|-------------|
{{ range .SubCommands }}| [{{ .FullName }}]({{ wikiLink .FullName }}) | {{ .Short }} |
{{ end }}{{ end }}
{{ if .ParentName }}
---
**Parent command:** [{{ .ParentName }}]({{ wikiLink .ParentName }})
{{ end }}
`
Loading