Skip to content

hdi_isfolder shall always be set in lower case on backend #3312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vibhansa-msft wants to merge 3 commits into
base: main
Choose a base branch
from
Open

hdi_isfolder shall always be set in lower case on backend #3312

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd81fc5
hdi_isfolder shall always be set in lower case on backend
vibhansa-msft Dec 3, 2025
52c1a3c
Comment added
vibhansa-msft Dec 3, 2025
73ca09b
Merge branch 'main' into vibhansa/hdi_case_correction
vibhansa-msft Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ste/sender-blobFolders.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,12 +187,12 @@ func (b *blobFolderSender) EnsureFolderExists() error {
}
}

// TODO (gapra): figure out better way to deal with hdi_isfolder metadata key capitalization
Copy link
Member

@gapra-msft gapra-msft Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should apply this to is_symlink too

Copy link
Member Author

@vibhansa-msft vibhansa-msft Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While copying symlinks we are creating the metadata with all lower case explicitly:

func (s *blobSymlinkSender) SendSymlink(linkData string) error {
	err := s.getExtraProperties()
	if err != nil {
		return fmt.Errorf("when getting additional folder properties: %w", err)
	}
	s.metadataToApply["is_symlink"] = to.Ptr("true")

Copy link
Member Author

@vibhansa-msft vibhansa-msft Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case of blob to blob copy with preserve-symlink flags here is my output:

   GET https://vikasfuseblob.blob.core.windows.net/testcntgo1/abcd%2Fa.lnk?...
   Accept: application/xml
   User-Agent: AzCopy/10.32.0~preview.1 azsdk-go-azblob/v1.6.2 (go1.25.1; linux)
   X-Ms-Client-Request-Id: 9602ecc6-11c6-468a-6ec4-373ccafae6e3
   x-ms-version: 2025-07-05
   --------------------------------------------------------------------------------
   RESPONSE Status: 200 OK
   ...
   X-Ms-Lease-Status: unlocked
   X-Ms-Meta-Is_symlink: true
   ...
  --------------------------------------------------------------------------------
   PUT https://vikasfusename.blob.core.windows.net/testcntgo1/abcd%2Fa.lnk?...
  ...
   x-ms-blob-type: BlockBlob
   x-ms-meta-is_symlink: true
   x-ms-version: 2025-07-05
  ...

// Always set this metadata in lower case while creating directories
if b.metadataToApply["Hdi_isfolder"] != nil {
b.metadataToApply["Hdi_isfolder"] = to.Ptr("true") // Set folder metadata flag
} else {
b.metadataToApply["hdi_isfolder"] = to.Ptr("true") // Set folder metadata flag
delete(b.metadataToApply, "Hdi_isfolder")
}
b.metadataToApply["hdi_isfolder"] = to.Ptr("true") // Set folder metadata flag

err = b.getExtraProperties()
if err != nil {
return fmt.Errorf("when getting additional folder properties: %w", err)
Expand Down
Loading