feat: drift for Kubelet Client ID #888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthchr
force-pushed
the
matthchr/kubelet-identity-drift
branch
from
32a9edf to
bbdeb68
Compare
matthchr
commented
May 14, 2025
charliedmcb
reviewed
May 15, 2025
charliedmcb
reviewed
May 15, 2025
Contributor
charliedmcb
left a comment
charliedmcb
left a comment
There was a problem hiding this comment.
Overall, looks good, but need to check the bootstrappingclient case
charliedmcb
reviewed
May 15, 2025
matthchr
force-pushed
the
matthchr/kubelet-identity-drift
branch
from
bbdeb68 to
6e4fe58
Compare
jackfrancis
reviewed
May 16, 2025
jackfrancis
reviewed
May 16, 2025
matthchr
force-pushed
the
matthchr/kubelet-identity-drift
branch
from
d7bf4c3 to
dfacd24
Compare
jackfrancis
reviewed
May 16, 2025
matthchr
force-pushed
the
matthchr/kubelet-identity-drift
branch
2 times, most recently
from
5cd7333 to
3eff98e
Compare
charliedmcb
reviewed
May 16, 2025
matthchr
force-pushed
the
matthchr/kubelet-identity-drift
branch
from
3eff98e to
0857587
Compare
charliedmcb
previously approved these changes
May 16, 2025
Contributor
charliedmcb
left a comment
charliedmcb
left a comment
There was a problem hiding this comment.
lgtm, assuming bootstrappingclient ordering is entirely covered.
pkg/providers/imagefamily/customscriptsbootstrap/provisionclientbootstrap.go
Show resolved
Hide resolved
* Add kubernetes.azure.com/kubelet-identity-client-id label to all nodes, to match what AKS does. * Drift nodes if the expected kubelet-identity-client-id has changed. * Does not drift if the node doesn't have the AKS Kubelet ClientID label set.
matthchr
force-pushed
the
matthchr/kubelet-identity-drift
branch
from
0857587 to
fd51e56
Compare
tallaxes
approved these changes
May 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How was this change tested?
kubernetes.azure.com/kubelet-identity-client-id=fcd9a498-b00b-4757-8c2a-90f6ede47610. Changing it at the configmap scope results in drift and the new node coming up with the new label.Does this change impact docs?
Release Note