Rearrange the chrono project, make the windows chrono stuff a separat… #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmJayGee
deleted the
micgrier/fix-windows-chrono-casts-install-location
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my neverending attempt to figure out how to arrange the platform independent vs. platform dependent parts of the code, I had rearranged the code and headers for chrono so that the platform dependent code was beneath the platform independent top level library target.
however this did not really permit the subdirectory to cleanly inject the
windows_chrono_casts.hheader into them/include namespace.The latest workaround here is to make the windows chrono support a separate target, m_windows_chrono, beneath m_chrono.
I don't know if this is the right approach. Maybe it is, maybe I can add m_windows_chrono as a link library of the m_chrono conditionally. But just because it can be done doesn't mean it should.
It would be nice if there was a nicer "paved path" for this kind of thing.