add failsafe_deserialize #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iscai-msft
commented
Jan 22, 2021
| @@ -1486,6 +1486,25 @@ def _classify_target(self, target, data): | |||
| pass # Target is not a Model, no classify | |||
| return target, target.__class__.__name__ | |||
|
|
|||
| def failsafe_deserialize(self, target_obj, response_data, content_type=None): | |||
There was a problem hiding this comment.
made the signature the same as __call__, since I wanted calling failsafe_deserialize the same as calling deserializer()
iscai-msft
commented
Jan 22, 2021
msrest/serialization.py
Outdated
| :param str/dict data: The response data to deseralize. | ||
| """ | ||
| try: | ||
| data = self._unpack_content(response_data, content_type) |
There was a problem hiding this comment.
added this content unpacking line, since call does content unpacking of the data as well, and as this method doesn't enter __call__, added this code here
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
==========================================
+ Coverage 86.32% 87.05% +0.73%
==========================================
Files 25 25
Lines 2749 2835 +86
==========================================
+ Hits 2373 2468 +95
+ Misses 376 367 -9
Continue to review full report at Codecov.
|
lmazuel
approved these changes
Jan 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.