Draft: Add Eddsa signature validation algorithms. fix #2426#2427
Open
wparad wants to merge 1 commit intoAzureAD:devfrom
Open
Draft: Add Eddsa signature validation algorithms. fix #2426#2427wparad wants to merge 1 commit intoAzureAD:devfrom
wparad wants to merge 1 commit intoAzureAD:devfrom
Conversation
Author
|
@microsoft-github-policy-service agree company="Rhosys AG" |
Contributor
|
@wparad we are discussing this internally. |
brentschmaltz
suggested changes
Jun 13, 2024
Contributor
brentschmaltz
left a comment
There was a problem hiding this comment.
We need to see test cases for all the additional algorithms.
It would be best to create a new file for theses tests.
Author
|
@brentschmaltz Not just the unit tests, the code for the implementation is missing. Can you give me some pointers on where to write that implementation. It's very hard to understand a lot of the nomenclature that is being used here. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Eddsa signature validation algorithms. fix #2426
Add in EdDSA almost everywhere. Still missing:
At this point, I'm looking for encouragement to continue this PR.
Thanks,
Warren