Update MicrosoftIdentityModelCurrentVersion to 8.16.1#3418
Closed
Update MicrosoftIdentityModelCurrentVersion to 8.16.1#3418
Conversation
* Local commit * Updated the tests to accomodate the changes to groups * Added an end to end test for JwtSecurityTokenHandler
…ft.Json entry (#3393) * Initial plan * Remove outdated Newtonsoft.Json entry from cgmanifest.json Co-authored-by: saurabhsathe-ms <197688485+saurabhsathe-ms@users.noreply.github.com> * Delete cgmanifest.json file as empty registrations array is not needed Co-authored-by: saurabhsathe-ms <197688485+saurabhsathe-ms@users.noreply.github.com> * Revert "Delete cgmanifest.json file as empty registrations array is not needed" This reverts commit ed051d5. * removed registrations array but kept the file --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: saurabhsathe-ms <197688485+saurabhsathe-ms@users.noreply.github.com> Co-authored-by: Saurabh Sathe <saurabhsathe@microsoft.com>
* rename parameter * rename bool in tests
* Initial plan * Add System.Security.Cryptography.AesGcm support for .NET 6+ Co-authored-by: westin-m <127992899+westin-m@users.noreply.github.com> * Update tests to support AesGcm on .NET 6+ Co-authored-by: westin-m <127992899+westin-m@users.noreply.github.com> * Address code review feedback - use consistent null checking Co-authored-by: westin-m <127992899+westin-m@users.noreply.github.com> * move conditions for readability --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: westin-m <127992899+westin-m@users.noreply.github.com>
* Initial plan * Add CancellationToken parameter to ValidateTokenAsync methods Co-authored-by: kllysng <69649063+kllysng@users.noreply.github.com> * Pass CancellationToken through internal validation methods Co-authored-by: kllysng <69649063+kllysng@users.noreply.github.com> * add cancellation token to tests and SHR call * Add overloads for internal methods to preserve binary compatibility Co-authored-by: kllysng <69649063+kllysng@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kllysng <69649063+kllysng@users.noreply.github.com> Co-authored-by: Kelly Song <kellysong@microsoft.com>
* Completed changes to SymmettricKeyWrapProvider! * Local commit * Resolved issues with KeyVaultVerify * FIxed KeyWrapProvider tests * Updated reference test for dotnet 10
…3409) * Initial plan * Add AppContext switch and update log levels for IDX10239 and IDX10234 Co-authored-by: RojaEnnam <63254595+RojaEnnam@users.noreply.github.com> * Add comprehensive tests for log level changes Co-authored-by: RojaEnnam <63254595+RojaEnnam@users.noreply.github.com> * Fix misleading comment in test helper class Co-authored-by: RojaEnnam <63254595+RojaEnnam@users.noreply.github.com> * Add logger cleanup to prevent test pollution Co-authored-by: RojaEnnam <63254595+RojaEnnam@users.noreply.github.com> * Remove extra blank lines in test methods Co-authored-by: RojaEnnam <63254595+RojaEnnam@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: RojaEnnam <63254595+RojaEnnam@users.noreply.github.com>
Co-authored-by: marcinzo <marcinzo@microsoft.com>
- Updated TenantIdAsGuid: f645ad92-e38d-4d1a-b510-d1b09a74a8ca -> 10c419d4-4a50-45b2-aa4e-919fb84df24f - Updated V1Issuer, V1IssuerWithoutTrailingSlash, and V1IssuerPPE constants - Updated test assertions in MicrosoftIdentityIssuerValidatorTest - All 143 tests in Microsoft.IdentityModel.Validators.Tests pass successfully
* Added helper class and methods to track signature validation telemetry. Added tests * Added a counter for signature validation. Updated ITelemetryClient interface and TelemetryClient to support the new telemetry. Added null telemetry client for no op * Added telemetry to JWT and SAML/SAML2 handlers. Expanded catching of exceptions to identify the stage at which the signature validation failed. * Added tests * Addressed Copilot's feedback * Reverted readonly changes to allow setting the telemetry client in tests * Replaced lock with volatile modifier for immutable array, removed the hashset in favour of the array to avoid converting in the getter. * Updated CryptoTelemetry's public API and tests * Added benchmarks for signature validation telemetry * Removed issuer caching from CryptoTelemetry signature validation telemetry. Updated tests * Updated public API to match the updated enable telemetry method * Addressed PR feedback - Rename _telemetryClient to TelemetryClient in all token handlers and update all references accordingly. - Simplify CryptoTelemetry.GetTrackedIssuerOrOther: now matches tracked issuers by substring (case-insensitive) instead of parsing host; remove ExtractHostFromIssuer. - Update comments to clarify substring matching and its limitations. - Remove TelemetryConfiguration enum from benchmarks; update benchmark attributes and tracked issuer values for consistency. - Refactor and expand CryptoTelemetry tests: remove host extraction tests, consolidate key algorithm ID tests, and add more scenarios for tracked issuer matching and allowlist filtering. - Update API documentation to reflect field renaming. - Overall, unify telemetry client usage and streamline issuer tracking logic, with tests updated to match new behavior. * Removed case insensitive comparison for telemetry issuer extraction based on PR feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.