-
Notifications
You must be signed in to change notification settings - Fork 464
Add ML-DSA (FIPS 204) post-quantum signature support #3479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
d808604
Add ML-DSA (FIPS 204) post-quantum signature support
iNinja fc2be48
Refactor X509 adapter routing, fix telemetry, improve PFX loading
iNinja 71cccec
Route ECDSA X509 certs correctly, broaden PrivateKeyStatus handling, …
iNinja 3b17575
Fix HasPrivateKey/PrivateKeyStatus interaction, align AKP HasPrivateK…
iNinja 5bc48ff
Clear ConvertedSecurityKey on AKP x5c validation failure
iNinja b4b8d0d
Dispose X509Certificate2 instances in tests
iNinja cede17f
Merge remote-tracking branch 'origin/dev8x' into iinglese/ml-dsa-8x-v2
iNinja 71fe548
Clean up InternalAPI.Unshipped.txt: keep only ML-DSA entries
iNinja 897f707
Move ML-DSA PublicAPI entries from per-TFM to shared root file
iNinja 8b48106
Merge remote-tracking branch 'origin/dev8x' into iinglese/ml-dsa-8x-v2
iNinja 785d8d3
Merge branch 'dev8x' into iinglese/ml-dsa-8x-v2
iNinja 31e1aac
Make MlDsaSecurityKey disposable and dispose MlDsaPublicKey on AKP re…
ed49730
Update ComputeJwkThumbprint() to properly dispose ML-DSA key object
94c9f8c
Clone MLDsa per AsymmetricAdapter for thread safety
d607a42
Remove TFM condition compilation of ML-DSA and use sign operation as …
445d578
Share ML-DSA between adapters in case of non-exportable seed or priva…
e934f35
Merge branch 'dev8x' into iinglese/ml-dsa-8x-v2
cpp11nullptr f803041
Merge branch 'dev8x' into iinglese/ml-dsa-8x-v2
cpp11nullptr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| <!-- Directory.Build.targets is imported after NuGet package .targets files, | ||
| so target overrides here take effect over package-defined InitialTargets. --> | ||
| <Project> | ||
|
|
||
| <!-- Microsoft.Bcl.Cryptography 10.0.2 and its transitive dependency System.Formats.Asn1 | ||
| emit TFM support warnings on net6.0. ML-DSA functionality is validated on net6.0 | ||
| via the compatibility package and covered by the cross-TFM test suite. | ||
| These overrides suppress only these specific package warnings — any new package | ||
| that introduces TFM warnings will still surface normally. | ||
| Note: Condition="false" applies unconditionally, but the package .targets files | ||
| only fire on unsupported TFMs (net6.0), so this has no effect on net8.0+. | ||
| Remove when net6.0 is dropped from SrcTargets. --> | ||
| <Target Name="NETStandardCompatError_Microsoft_Bcl_Cryptography_net8_0" | ||
| Condition="false" /> | ||
| <Target Name="NETStandardCompatError_System_Formats_Asn1_net8_0" | ||
| Condition="false" /> | ||
|
|
||
| </Project> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.