Async versions of BeforeAccess and AfterAccess

[dmcweeney]

Hi,

Any plans to provide async versions of the BeforeAccess and AfterAccess notifications?

Thanks

Donal

[jmprieur]

@dmcweeney can you please explain your scenario?

[dmcweeney]

Hi @jmprieur , sorry for the delay in getting back.
Looking at the code I see in the async methods that require access to TokenCache it calls the BeforeAccess and AfterAccess synchronously.
In my case, I then was calling the IDistributedCache async methods to get/set the token values in the redis cache up on Azure. And after a few calls my web app deadlocked.
I used the .GetAwaiter().GetResult() on these calls which can result in deadlocks, and there was lots of other recommendations out these on using Task.Run etc.

However the most frequent recommendation was to re-evaluate the code, and that the async methods should be calling async methods through the lifetime of the operation.

Thus my request! Does that explain the scenario ok?

Thanks

Donal

[jmprieur]

Thanks @dmcweeney for this explanation. It's better for us to understand the scenario (you get deadlocks)

[AlexandreArpin]

Gonna ride on this, it's a frequent use case to persist the Token Cache in a distributed manner, it'd be nice to have a TokenCache implementation that uses Async signature.

Now that you decorate the Token Cache instead of inheriting from it, it's a bit less annoying but those BeforeAccess/AfterAccess could really use having an Async signature since most of the time the implementation are gonna be doing IO of some sort.

[juunas11]

👍 for this. We should not have to do blocking calls on async APIs.

[henrik-me]

Discussed this during triage. Seems like this will benefit webapps the most, thus prioritizing for v3. Not blocking a specific v3 release but should be in an update soon after if not included.