For proactive refresh log error to otel and change token source to IDP#4561
Merged
Conversation
github-actions
Bot
requested review from
bgavrilMS,
gladjohn,
pmaytak and
trwalke
bgavrilMS
reviewed
Jan 23, 2024
bgavrilMS
reviewed
Jan 23, 2024
bgavrilMS
reviewed
Jan 23, 2024
bgavrilMS
reviewed
Jan 23, 2024
bgavrilMS
reviewed
Jan 25, 2024
bgavrilMS
reviewed
Jan 25, 2024
bgavrilMS
approved these changes
Jan 25, 2024
trwalke
reviewed
Jan 26, 2024
trwalke
approved these changes
Jan 26, 2024
Member
|
Isn't this going to skew the cache hit ratio metrics resulting in potential customer concern for those who monitor this? Also, while there is a token refresh, the token returned to the user is not the one acquired to from the endpoint. Are we sure this is the right thing to change? |
Contributor
Author
Yes, I will be changing the token source back to cache, we should be using both token source and cache refresh reason when generating metrics. Thanks |
pmaytak
approved these changes
Feb 7, 2024
Member
|
Hi @neha-bhargava - this has been opened for quite a while. Would you like the team to review again? |
pmaytak
approved these changes
Feb 16, 2024
…ProactiveRefreshTests.cs Co-authored-by: Peter <34331512+pmaytak@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4492
Changes proposed in this request
Add telemetry for background request for proactive token refresh.
Log error to otel if the background process fails.
Added tags ApiId and IsProactiveRefresh to MsalFailure counter
Added tag CacheRefreshReason to histograms MsalTotalDuration, MsalDurationInL1CacheInUs, MsalDurationInL2Cache
Testing
Added unit tests and integration tests
Performance impact
Documentation