Skip to content

Fix a bug in handleRedirectPromise when invoked after logoutRedirect #7680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 3, 2025
Merged

Fix a bug in handleRedirectPromise when invoked after logoutRedirect #7680

merged 5 commits into from
Apr 3, 2025

Conversation

konstantin-msft
Copy link
Collaborator

@konstantin-msft konstantin-msft commented Apr 2, 2025 •
edited
Loading

  • Add interaction type to "interaction_in_progress" temporary key to return from "handleRedirectPromise" early if invoked after signout. This fixes a bug with the login flow being blocked after user logs out and improves sign-out perf.
  • Add try-catch block to the first parst of "handleRedirectPromise" to make sure users can recover from "no_token_request_cache_error" if session storage gets cleared during page navigation.
  • Simplify redirect telemetry instrumentation.

@github-actions github-actions bot added the msal-browser Related to msal-browser package label Apr 2, 2025
peterzenz
peterzenz previously approved these changes Apr 2, 2025
View reviewed changes
@konstantin-msft konstantin-msft merged commit 972b993 into dev Apr 3, 2025
7 checks passed
@konstantin-msft konstantin-msft deleted the fix_redirect_bug branch April 3, 2025 18:38
peterzenz
peterzenz reviewed Apr 3, 2025
View reviewed changes
Copy link
Contributor

@peterzenz peterzenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterzenz peterzenz peterzenz left review comments

@lalimasharda lalimasharda lalimasharda approved these changes

@jo-arroyo jo-arroyo jo-arroyo approved these changes

@sameerag sameerag Awaiting requested review from sameerag sameerag is a code owner

@tnorling tnorling Awaiting requested review from tnorling tnorling is a code owner

@hectormmg hectormmg Awaiting requested review from hectormmg hectormmg is a code owner

@shylasummers shylasummers Awaiting requested review from shylasummers shylasummers is a code owner

Assignees
No one assigned
Labels
msal-browser Related to msal-browser package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@konstantin-msft @peterzenz @lalimasharda @jo-arroyo