Skip to content

Add enable_pii_log and wire it up with MsalRuntime #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Conversation

rayluo
Copy link
Collaborator

@rayluo rayluo commented Aug 18, 2023

A new enable_pii_log parameter will be added into API surface. To use this new behavior, an app would need to declare dependency of msal>=1.24,<2.

This will resolve #568

@rayluo rayluo changed the title Add enable_pii and wire it up with MsalRuntime Add enable_pii_log and wire it up with MsalRuntime Aug 18, 2023
@rayluo rayluo merged commit bba6b14 into dev Aug 23, 2023
@rayluo rayluo deleted the enable-pii branch August 23, 2023 08:10
@rayluo rayluo mentioned this pull request Sep 8, 2023
@jiasli
Copy link
Contributor

jiasli commented May 16, 2024

Can we make sure msal_telemetry contains no PII when enable_pii_log is set to True? In my opinion, msal_telemetry should not contain PII under any circumstances.

@rayluo
Copy link
Collaborator Author

rayluo commented May 16, 2024

Can we make sure msal_telemetry contains no PII when enable_pii_log is set to True? In my opinion, msal_telemetry should not contain PII under any circumstances.

If I remember correctly, that was indeed the design. enable_pii_log only affects logs. I'm also CCing @MSamWils , @ashok672 , @fengga to keep me honest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MSAL logging discrepancy
2 participants