[Performance degradation] slower integration tests when using WebApplicatoryFactory, jump from 3.0.1 to 3.1.0

[tiaringhio]

When upgrading my dotnet web api from dotnet 8 to dotnet 9 i noticed that my integration tests that run via WebApplicationFactory run noticeably slower (orders of magnitude).

my small suits of tests to compare is made of 10 test that make various HTTP calls to my server including calls to the services that run in containers via testcontainers such as:

• SQL Server
• Azurite for storage
• Redis

The startup up times are about the same (give or take a couple of seconds) but the single HTTP calls are slower, the test have not been modified since changing the version

i have previously opened an issue on AspNetCore's repo and then found out why my tests were running slowly, it's the jump from Microsoft.Identity.Web 3.0.1 to Microsoft.Identity.Web 3.1.0, something there has been causing slowdowns in my tests.

i previously thought the issues was in Microsoft.AspNetCore.Authentication.JwtBearer but i did some tests and i found out that the real culprit is Microsoft.Identity.Web.GraphServiceClient

here's the before and after

with version 3.1.10

with version 3.0.1

as you can see the difference is there, it's a small difference for the small number of tests but a huge one for my whole suite that consists of around 1k.

i don't know what changed, can someone look into it? i can provide profiling if that helps.

i also tried upgrading to the latest version (3.6.2) but the performance hit it's the same

thank you

[keegan-caruso]

@tiaringhio - Profiling data would be helpful

[tiaringhio]

so, i've looked through the commits that go from 3.0.1 to 3.1.0 by looking here

3.0.1...3.1.0

i have not found anything that made my question what was written, i've tried proflling a single test but even though i see the performance hit i cannot figure out where it is in the data i'm shown (i'm very new to profiling), can it maybe be a transitive dependency for Microsoft.Identity.Web.GraphServiceClient that is causing the hit?

[keegan-caruso]

@tiaringhio Can you check your transitive dependencies: dotnet list package --include-transitive

And make sure all of the IdentityModel.* assemblies are up to date and on the same version?

[tiaringhio]

so, i have checked with the command you suggested, the version for my out is always the same

it's 8.0.1 for every instance

[jennyf19]

@tiaringhio thanks for the details. when you are on the latest Id Web, it should be referencing 8.3.1 is that the case? We are asking because there was a perf issue in 8.0.2 and we want to ensure you don't have that package referenced by accident somewhere. Can you share a link to your code, if on GitHub public?

[tiaringhio]

sorry @jennyf19, i ran the command against the 8.0.1 version, the result for the 3.6.2 version

i run my small suite of test before and after (upgrading Microsoft.Identity.Web.GraphServiceClient from 3.0.1 to 3.6.2) and the tests still run slow.

unfortunately i am not able to share the code as it is private, what i can confirm is that i'm not referencing the 8.0.2 version anywhere

[keegan-caruso]

@tiaringhio I'm not sure if we can help much without either profiling data or a reproduction of the issue of some kind.

If you could write a minimal example that shows the latency issue, we could also use that to investigate the issue.

[yzhoholiev]

At least one of the bugs introduced in the change set is splitting of the the authority.
The condition will always be true here:
3.0.1...3.1.0#diff-d90759b2d30ed4fbde754ce1f3a2da272a9de57792a8b14aeced23071f828e47R441

It should be something like:

if (authoritySpan.StartsWith("https://", StringComparison.OrdinalIgnoreCase)) // should we check for other schemes here? As an alternative we can search for the first :// here.
{
    authoritySpan= authoritySpan.Slice(8);
}
int indexTenant = authoritySpan.IndexOf('/');
if (indexTenant >= 0)

[keegan-caruso]

@yzhoholiev - thanks can you open a bug for this?