Making ClientAssertion class public to inherit IDWeb repo on dMSI lib #2079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This class needs to remain internal because we may change its implementation, especially around the cache.. You can derive from ClientAssertionProviderBase. |
Contributor
|
ClientAssertionProviderBase has an abstract method on line 21 "GetClientAssertion" which requires returning a Task < ClientAssertion >. Without the ability to make a ClientAssertion object, or otherwise altering the coupling here, there is no way to implement the abstract method required to derive ClientAssertionProviderBase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making ClientAssertion class public to inherit IDWeb repo on dMSI lib