Westinm/downstreamapi-logging #2206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log unauthenticated api call
misspellings in the api cause the same type of error, so include that information in this log
jennyf19
reviewed
Apr 18, 2023
jennyf19
reviewed
Apr 18, 2023
jennyf19
reviewed
Apr 18, 2023
src/Microsoft.Identity.Web.DownstreamApi/DownstreamApi.Logger.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Apr 18, 2023
src/Microsoft.Identity.Web.DownstreamApi/DownstreamApi.Logger.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Apr 18, 2023
src/Microsoft.Identity.Web.DownstreamApi/DownstreamApi.Logger.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Apr 18, 2023
src/Microsoft.Identity.Web.DownstreamApi/DownstreamApi.HttpMethods.cs
Outdated
Show resolved
Hide resolved
Collaborator
|
Looks good so far. Do you plan to do more or ready to move out of draft? |
Contributor
Author
Ready to move out of draft |
jmprieur
reviewed
Apr 18, 2023
jennyf19
reviewed
Apr 18, 2023
src/Microsoft.Identity.Web.DownstreamApi/DownstreamApiLoggingEventId.cs
Outdated
Show resolved
Hide resolved
jmprieur
approved these changes
Apr 18, 2023
Collaborator
jmprieur
left a comment
jmprieur
left a comment
There was a problem hiding this comment.
LGTM
Follow-up is to move the code in the .tt file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce logging to DonwstreamApi for errors that occur due to misconfigured appsettings (base url, relative path, typos in api) and for unauthenticated requests.