create design_proposal.md #2523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westin-m
approved these changes
Oct 16, 2023
JoshLozensky
requested changes
Oct 16, 2023
|
|
||
| 1-2 sentences. Say what this is about. | ||
|
|
||
| ## Motivation and goals |
Contributor
There was a problem hiding this comment.
nit: can we change goals to "success criteria" I've found this phrasing generally results in more specific and measurable goals/criteria
|
|
||
| ## In scope | ||
|
|
||
| A list of major scenarios, perhaps in priority order. |
Contributor
There was a problem hiding this comment.
What are "major scenarios"? Can we define this and/or provide an example?
|
|
||
| ## Out of scope | ||
|
|
||
| Scenarios you explicitly want to exclude. |
Contributor
There was a problem hiding this comment.
Same comment as above.... is feature an appropriate descriptor here?
Contributor
Author
There was a problem hiding this comment.
Great comments Josh!! Will fix in later iteration!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.