Skip to content

Remove PreviousVersion Attributes#2723

Merged
FraserGreenroyd merged 1 commit intomainfrom
BHoM-RemovePreviousVersion50
Jan 5, 2022
Merged

Remove PreviousVersion Attributes#2723
FraserGreenroyd merged 1 commit intomainfrom
BHoM-RemovePreviousVersion50

Conversation

@BHoMBot
Copy link
Member

@BHoMBot BHoMBot commented Jan 5, 2022

Remove PreviousVersion attributes for 5.0 versioning.

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Jan 5, 2022
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from a DevOps perspective, will be merged when the bot is back online.

Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

There are 13 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • versioning

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check dataset-compliance
@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • dataset-compliance
  • copyright-compliance

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • ready-to-merge

There are 9 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2022

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is copyright-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a CI/CD instruction. I am authorising dispensation to be granted on check ref. 4717253203

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a CI/CD instruction. I am authorising dispensation to be granted on check ref. 4717253203

BHoMBot is about to do automatic copyright updates so dispensating for now for the bot to handle.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2022

@FraserGreenroyd I have now provided a passing check on reference 4717253203 as requested.

@FraserGreenroyd FraserGreenroyd merged commit 2bb3693 into main Jan 5, 2022
@FraserGreenroyd FraserGreenroyd deleted the BHoM-RemovePreviousVersion50 branch January 5, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:compliance Non-conforming to code guidelines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments