Skip to content

Facade_Engine: SAM and CAM methods fixed and improved#2731

Merged
FraserGreenroyd merged 1 commit intomainfrom
Facade_Engine-#2662-SAMandCAMImprovements
Jan 25, 2022
Merged

Facade_Engine: SAM and CAM methods fixed and improved#2731
FraserGreenroyd merged 1 commit intomainfrom
Facade_Engine-#2662-SAMandCAMImprovements

Conversation

@enarhi
Copy link
Member

@enarhi enarhi commented Jan 14, 2022

Issues addressed by this PR

Closes #2662

Fixed reliance on Psi/U Value fragments assigned to Construction properties rather than the element itself, and added multiple opening area weighted functionality.

Test files

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/BHoM_Engine/Facade_Engine/%232662-SAMandCAMMethodUpdates?csf=1&web=1&e=HgP13D

@enarhi enarhi requested a review from vgreen-BH January 14, 2022 01:02
@enarhi enarhi self-assigned this Jan 14, 2022
@enarhi
Copy link
Member Author

enarhi commented Jan 14, 2022

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 14, 2022

@enarhi to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 14, 2022

@enarhi to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

There are 4 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 14, 2022

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@enarhi
Copy link
Member Author

enarhi commented Jan 14, 2022

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 14, 2022

@enarhi to confirm, the following checks are now queued:

  • versioning

There are 21 requests in the queue ahead of you.

@enarhi
Copy link
Member Author

enarhi commented Jan 14, 2022

@BHoMBot check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 14, 2022

@enarhi to confirm, the following checks are now queued:

  • null-handling

There are 23 requests in the queue ahead of you.

@enarhi enarhi force-pushed the Facade_Engine-#2662-SAMandCAMImprovements branch from 7f2edd9 to cf00389 Compare January 14, 2022 17:28
@enarhi enarhi force-pushed the Facade_Engine-#2662-SAMandCAMImprovements branch from cf00389 to a856443 Compare January 24, 2022 23:42
Copy link
Contributor

@vgreen-BH vgreen-BH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enarhi
Copy link
Member Author

enarhi commented Jan 25, 2022

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 25, 2022

@enarhi to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

There are 19 requests in the queue ahead of you.

@enarhi
Copy link
Member Author

enarhi commented Jan 25, 2022

@BHoMBot check versioning
@BHoMBot check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 25, 2022

@enarhi to confirm, the following checks are now queued:

  • versioning
  • null-handling

@enarhi
Copy link
Member Author

enarhi commented Jan 25, 2022

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 25, 2022

@enarhi to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

There are 17 requests in the queue ahead of you.

@enarhi
Copy link
Member Author

enarhi commented Jan 25, 2022

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 25, 2022

@enarhi to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 25, 2022

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 25, 2022

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 25, 2022

The check null-handling has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 25, 2022

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

@enarhi
Copy link
Member Author

enarhi commented Jan 25, 2022

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 25, 2022

@enarhi to confirm, the following checks are now queued:

  • ready-to-merge

@enarhi enarhi added the type:feature New capability or enhancement label Jan 25, 2022
@enarhi
Copy link
Member Author

enarhi commented Jan 25, 2022

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 25, 2022

@enarhi to confirm, the following checks are now queued:

  • ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 90e8263 into main Jan 25, 2022
@FraserGreenroyd FraserGreenroyd deleted the Facade_Engine-#2662-SAMandCAMImprovements branch January 25, 2022 21:00
@FraserGreenroyd FraserGreenroyd changed the title SAM and CAM methods fixed and improved Facade_Engine: SAM and CAM methods fixed and improved Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:feature New capability or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Facade_Engine: Update SAM and CAM methods for Fragments applied to properties

3 participants

Comments