Relax XML parser to allow global preferences following venue(s) #5689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* TODO: day_prefs, network_wifi_only * See: #5682
brevilo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5682
Description of the Change
See referenced issue for motivation and approach. The idea is to allow for preference elements following the "correct" venue, instead of just skipping them. Yes, this makes the parsing a tiny more inefficient but the extra fault-tolerance should be more than worth it. The augmented conditionals mean that any tag is set only once unless its the one for the host's venue. That means:
Note, I haven't yet covered the following elements because I need your input:
day_prefs: do they need special treatment? Are they also venue-specific?network_wifi_only: it's part of theGLOBAL_PREFS_MASKmask but it's not being set. Why?Release Notes
Rrelax XML parser to allow global preferences following venue(s)