Skip to content

Inspector V2: Tools Pane Init #16798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexchuber
Copy link
Contributor

@alexchuber alexchuber commented Jun 24, 2025

The components of the Tools pane are lumped into three extensible categories, which can be installed via the Extensions Manager

  • Export: the .gltf and .babylon export buttons and their options. Serializers package is dynamically loaded
  • Capture: tools like screenshots, diffs captures, video recording, etc. GIF optimizer package is hopefully not statically loaded, but haven't confirmed
  • Import: import animations and, later, maybe glTF validator results

Left TODO

  • All services are attached to the Scene entity, but this should be changed such that they're always present
  • OptionsLine component, FileLineComponent, AccordionPane
  • Best React practices pass
  • simplify service section/content registration
  • All of gltfComponent.tsx, including gltf validator

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 24, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 24, 2025

Reviewer - this PR has made changes to one or more package.json files.

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 24, 2025

Graph tools CI has failed you can find the test results at:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16798/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 24, 2025

Building or testing the sandbox has failed.

If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16798/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 24, 2025

Building or testing the playground has failed.

If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16798/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 24, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 24, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 24, 2025

@alexchuber alexchuber force-pushed the inspector-v2-tools-init branch from 4559e7a to a834b39 Compare June 24, 2025 15:30
@bjsplat
Copy link
Collaborator

bjsplat commented Jun 24, 2025

Reviewer - this PR has made changes to one or more package.json files.

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 24, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 24, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants