fix: isolate permission callbacks by permission type #1500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VanRooyHenri
force-pushed
the
fix/permission-callback-isolation
branch
3 times, most recently
from
25206ff to
1584721
Compare
VanRooyHenri
force-pushed
the
fix/permission-callback-isolation
branch
from
1584721 to
9bfb065
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Callbacks were stored as static variables shared across all Permission instances, causing callbacks to fire for wrong permissions. Changed to use Maps keyed by Permission to ensure each permission has its own isolated callbacks.
Fixes issue where Permission.locationWhenInUse callbacks would trigger when any other permission changed state.
#1414