-
-
Notifications
You must be signed in to change notification settings - Fork 451
Avoid calling getDownloadURL in favor of directly getting data #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for this PR! I hit an error due to CacheControl being null. I fixed it with this follow on change: |
Thank you! I added your changes. I'll have to finish this on the weekend as another project is taking up my time |
I just recently checked this again and it looks like it's working for me as expected. It might've been a cached older package I was using by accident. I'll move this out of draft and work on checklist. Pleas feel free to offer objections to my alternative |
I'm afraid this is too stale. Closing for now to allow NNBD PR prior to any action here |
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
This would handle #240. I'm scared this adds an extra network call (possibly two but I don't think
getReferenceFromUrl
is a network req) so I won't I expect anything from this PR and the simplicity ofgetDownloadURL
might be preferred.I think the original bug is that the the extension is not being carried through to the path in either my implementation or the current one and that's what's causing this line to fail in the original issue:
💥 Does this PR introduce a breaking change?
No
📝 Links to relevant issues/docs
firebase/firebase-js-sdk#76
🤔 Checklist before submitting