fix: TradeResponse class

[cuongph87]

Types of changes

• Fixes Fix TradeResponse class #90
• Adds required modifier to always-present properties

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• I have read the CONTRIBUTING document.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

---

Note

Refactors TradeResponse to properly model orderbook and liquidity pool trades (required/nullable fields, links, assets), and updates tests and fixtures to validate both trade types.

• Responses:
  • Refactor TradeResponse:
    • Add trade_type, liquidity_pool_fee_bp, base_liquidity_pool_id, counter_liquidity_pool_id.
    • Make always-present fields required; adjust others to nullable.
    • Fix CounterAsset property (was CountAsset).
    • Change _links.base/_links.counter to non-generic Link.
    • Remove unused OfferId field; keep base_offer_id/counter_offer_id.
• Tests:
  • Replace tradePage.json with tradePageOrderBook.json and add tradePageLiquidityPool.json.
  • Update TradesRequestBuilderTest.TestTradesExecute to use orderbook fixture and new assertions.
  • Expand TradesPageDeserializerTest with serialize/deserialize tests and assertions for both orderbook and liquidity pool trades.
• Project:
  • Update .csproj to include new test data files and remove the old trade page fixture.

^{Written by Cursor Bugbot for commit 5a5b79c. Configure here.}

[Copilot]

Pull request overview

This PR fixes issues in the TradeResponse class related to incorrect property nullability and adds comprehensive test coverage for both orderbook and liquidity pool trade types. The changes mark always-present properties as required, make conditionally-present properties nullable, and update the class to be sealed. Additionally, it corrects a previously misspelled property name (CountAsset → CounterAsset).

Key Changes

• Added required modifier to properties that are always present in trade responses (e.g., Id, PagingToken, TradeType)
• Made conditionally-present properties nullable (e.g., BaseAccount, LiquidityPoolFeeBp, BaseOfferId)
• Fixed typo: renamed CountAsset to CounterAsset

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
StellarDotnetSdk/Responses/TradeResponse.cs	Updated property nullability with required and nullable modifiers, added comprehensive XML documentation, fixed property name typo, and changed to sealed class
StellarDotnetSdk.Tests/TestData/Responses/tradePageOrderBook.json	New test data file containing orderbook trade example
StellarDotnetSdk.Tests/TestData/Responses/tradePageLiquidityPool.json	New test data file containing liquidity pool trade examples
StellarDotnetSdk.Tests/TestData/Responses/tradePage.json	Removed outdated test data file
StellarDotnetSdk.Tests/StellarDotnetSdk.Tests.csproj	Updated test data file references
StellarDotnetSdk.Tests/Responses/TradesPageDeserializerTest.cs	Replaced single test with separate tests for orderbook and liquidity pool trades, with expanded assertions
StellarDotnetSdk.Tests/Requests/TradesRequestBuilderTest.cs	Updated to use new test data file and assertion method

[jopmiddelkamp]

bugbot run

[cursor]

✅ Bugbot reviewed your changes and found no bugs!

---