Skip to content

chore: unit test naming and docs#122

Merged
jopmiddelkamp merged 4 commits intomasterfrom
chore/unit-test-naming
Dec 18, 2025
Merged

chore: unit test naming and docs#122
jopmiddelkamp merged 4 commits intomasterfrom
chore/unit-test-naming

Conversation

@jopmiddelkamp
Copy link
Copy Markdown
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Comment thread StellarDotnetSdk.Tests/Accounts/AccountTest.cs
Comment thread StellarDotnetSdk.Tests/Assets/LiquidityPoolShareChangeTrustAssetTest.cs Outdated
Comment thread StellarDotnetSdk.Tests/MemoTest.cs
Comment thread StellarDotnetSdk.Tests/MemoTest.cs
Comment thread StellarDotnetSdk.Tests/Operations/FeeBumpOperationTest.cs
Comment thread StellarDotnetSdk.Tests/ServerTest.cs
Comment thread StellarDotnetSdk.Tests/Accounts/AccountTest.cs
Copy link
Copy Markdown
Contributor

@cuongph87 cuongph87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments:

  • It feels like most of the added XML comments are somewhat redundant. I think the docs should be omitted if the method name is descriptive enough. Only add meaningful context that isn't in the method name. What do you think?
  • Since we're already modifying a lot of files in this PR, maybe we should also try to get rid of as many warnings as possible. I've added several suggestions, but there are more.
  • Just a note: When I open certain files in Rider, I get warning "The file was loaded in a wrong encoding: 'UTF-8'", which caused by added BOM character. But after I remove the BOM and then discard the changes, next time I open the file, it works just fine. Maybe it's just my Rider. But this has only started happening recently.

@jopmiddelkamp jopmiddelkamp merged commit 839c062 into master Dec 18, 2025
4 checks passed
@jopmiddelkamp jopmiddelkamp deleted the chore/unit-test-naming branch December 18, 2025 15:52
@cuongph87 cuongph87 added the chore label Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants