chore: unit test naming and docs#122
Merged
jopmiddelkamp merged 4 commits intomasterfrom Dec 18, 2025
Merged
Conversation
cuongph87
reviewed
Dec 18, 2025
cuongph87
reviewed
Dec 18, 2025
cuongph87
reviewed
Dec 18, 2025
cuongph87
reviewed
Dec 18, 2025
cuongph87
reviewed
Dec 18, 2025
cuongph87
reviewed
Dec 18, 2025
cuongph87
reviewed
Dec 18, 2025
cuongph87
reviewed
Dec 18, 2025
Contributor
cuongph87
left a comment
There was a problem hiding this comment.
A few comments:
- It feels like most of the added XML comments are somewhat redundant. I think the docs should be omitted if the method name is descriptive enough. Only add meaningful context that isn't in the method name. What do you think?
- Since we're already modifying a lot of files in this PR, maybe we should also try to get rid of as many warnings as possible. I've added several suggestions, but there are more.
- Just a note: When I open certain files in Rider, I get warning "The file was loaded in a wrong encoding: 'UTF-8'", which caused by added BOM character. But after I remove the BOM and then discard the changes, next time I open the file, it works just fine. Maybe it's just my Rider. But this has only started happening recently.
060a2b0 to
a0b1777
Compare
cuongph87
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes