Skip to content

chore: operations unit test coverage#125

Merged
jopmiddelkamp merged 1 commit intomasterfrom
chore/operations-unit-test-coverage
Dec 22, 2025
Merged

chore: operations unit test coverage#125
jopmiddelkamp merged 1 commit intomasterfrom
chore/operations-unit-test-coverage

Conversation

@jopmiddelkamp
Copy link
Copy Markdown
Contributor

Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jopmiddelkamp jopmiddelkamp marked this pull request as ready for review December 22, 2025 09:12
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive unit test coverage for the ChangeTrustOperation class, testing constructor behavior, XDR serialization/deserialization, and round-trip scenarios for various asset types (native, CreditAlphaNum4, CreditAlphaNum12, and liquidity pool shares).

Key changes:

  • Adds 30+ test methods covering all public constructors and methods of ChangeTrustOperation
  • Tests edge cases like null parameters, zero limits, max limits, and unknown asset types
  • Validates XDR serialization/deserialization for all supported asset types
  • Tests both current and obsolete constructor overloads

Comment thread StellarDotnetSdk.Tests/Operations/ChangeTrustOperationTest.cs
@jopmiddelkamp jopmiddelkamp changed the title chore: operations unit test converage chore: operations unit test coverage Dec 22, 2025
@jopmiddelkamp jopmiddelkamp force-pushed the chore/operations-unit-test-coverage branch from 7cb90bf to 27b36d1 Compare December 22, 2025 13:04
@jopmiddelkamp jopmiddelkamp merged commit ee8a227 into master Dec 22, 2025
4 checks passed
@jopmiddelkamp jopmiddelkamp deleted the chore/operations-unit-test-coverage branch December 22, 2025 13:32
@cuongph87 cuongph87 added the chore label Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants