chore: operations unit test coverage#125
Merged
jopmiddelkamp merged 1 commit intomasterfrom Dec 22, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive unit test coverage for the ChangeTrustOperation class, testing constructor behavior, XDR serialization/deserialization, and round-trip scenarios for various asset types (native, CreditAlphaNum4, CreditAlphaNum12, and liquidity pool shares).
Key changes:
- Adds 30+ test methods covering all public constructors and methods of
ChangeTrustOperation - Tests edge cases like null parameters, zero limits, max limits, and unknown asset types
- Validates XDR serialization/deserialization for all supported asset types
- Tests both current and obsolete constructor overloads
7cb90bf to
27b36d1
Compare
cuongph87
approved these changes
Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Types of changes