Skip to content

chore: request unit test coverage#126

Merged
jopmiddelkamp merged 4 commits intomasterfrom
chore/requests-unit-test-coverage
Dec 23, 2025
Merged

chore: request unit test coverage#126
jopmiddelkamp merged 4 commits intomasterfrom
chore/requests-unit-test-coverage

Conversation

@jopmiddelkamp
Copy link
Copy Markdown
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive unit test coverage for several request builder classes in the SDK. The primary focus is testing URI construction, parameter handling, and exception scenarios.

Key changes:

  • Added new test coverage for PathsRequestBuilder (entirely new test file)
  • Extended test coverage for TransactionsRequestBuilder, OperationsRequestBuilder, and EffectsRequestBuilder
  • Tests cover URI building, parameter validation, null/empty argument handling, and data deserialization

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.

File Description
TransactionsRequestBuilderTest.cs Added tests for Transaction() method with URI/ID, null parameter validation, and IncludeFailed() with false value
PathsRequestBuilderTest.cs New comprehensive test file covering all PathsRequestBuilder methods including URI construction, parameter handling, and Execute()
OperationsRequestBuilderTest.cs Added tests for Operation() method, extensive null/empty/invalid parameter validation, and IncludeFailed() with false value
EffectsRequestBuilderTest.cs Added null parameter validation tests and liquidity pool URI construction tests with both LiquidityPoolId and string ID

Comment thread StellarDotnetSdk.Tests/Requests/OperationsRequestBuilderTest.cs Outdated
Comment thread StellarDotnetSdk.Tests/Requests/OperationsRequestBuilderTest.cs Outdated
Comment thread StellarDotnetSdk.Tests/Requests/OperationsRequestBuilderTest.cs Outdated
Comment thread StellarDotnetSdk.Tests/Requests/OperationsRequestBuilderTest.cs Outdated
Comment thread StellarDotnetSdk.Tests/Requests/OperationsRequestBuilderTest.cs Outdated
Comment thread StellarDotnetSdk.Tests/Requests/OperationsRequestBuilderTest.cs Outdated
Comment thread StellarDotnetSdk.Tests/Requests/OperationsRequestBuilderTest.cs Outdated
Comment thread StellarDotnetSdk.Tests/Requests/OperationsRequestBuilderTest.cs Outdated
@jopmiddelkamp jopmiddelkamp force-pushed the chore/requests-unit-test-coverage branch from 00a217b to 86bc254 Compare December 22, 2025 13:04
Comment thread StellarDotnetSdk.Tests/Requests/EffectsRequestBuilderTest.cs
Comment thread StellarDotnetSdk.Tests/Requests/PathsRequestBuilderTest.cs
Comment thread StellarDotnetSdk.Tests/Requests/TransactionsRequestBuilderTest.cs
Copy link
Copy Markdown
Contributor

@cuongph87 cuongph87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested.

@jopmiddelkamp jopmiddelkamp force-pushed the chore/requests-unit-test-coverage branch from 86bc254 to c5bdcc6 Compare December 22, 2025 13:32
@jopmiddelkamp jopmiddelkamp merged commit 2c7fba6 into master Dec 23, 2025
4 checks passed
@jopmiddelkamp jopmiddelkamp deleted the chore/requests-unit-test-coverage branch December 23, 2025 10:33
@cuongph87 cuongph87 added the chore label Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants