chore: request unit test coverage#126
Merged
jopmiddelkamp merged 4 commits intomasterfrom Dec 23, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive unit test coverage for several request builder classes in the SDK. The primary focus is testing URI construction, parameter handling, and exception scenarios.
Key changes:
- Added new test coverage for
PathsRequestBuilder(entirely new test file) - Extended test coverage for
TransactionsRequestBuilder,OperationsRequestBuilder, andEffectsRequestBuilder - Tests cover URI building, parameter validation, null/empty argument handling, and data deserialization
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| TransactionsRequestBuilderTest.cs | Added tests for Transaction() method with URI/ID, null parameter validation, and IncludeFailed() with false value |
| PathsRequestBuilderTest.cs | New comprehensive test file covering all PathsRequestBuilder methods including URI construction, parameter handling, and Execute() |
| OperationsRequestBuilderTest.cs | Added tests for Operation() method, extensive null/empty/invalid parameter validation, and IncludeFailed() with false value |
| EffectsRequestBuilderTest.cs | Added null parameter validation tests and liquidity pool URI construction tests with both LiquidityPoolId and string ID |
00a217b to
86bc254
Compare
cuongph87
reviewed
Dec 22, 2025
cuongph87
reviewed
Dec 22, 2025
cuongph87
reviewed
Dec 22, 2025
86bc254 to
c5bdcc6
Compare
cuongph87
approved these changes
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes