-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
feat - add vision chat for ollama_chat #6880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've completed my review and didn't find any issues... but I did find this bunny.
(\(\
( -.-)
o_(")(")
Files scanned
File Path | Reviewed |
---|---|
litellm/llms/ollama_chat.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-review
on this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-review
command in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-description
command in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolve
command in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Current Korbit Configuration
General Settings
Setting Value Review Schedule Automatic excluding drafts Max Issue Count 10 Automatic PR Descriptions ✅ Issue Categories
Category Enabled Naming ✅ Database Operations ✅ Documentation ✅ Logging ✅ Error Handling ✅ Systems and Environment ✅ Objects and Data Structures ✅ Readability and Maintainability ✅ Asynchronous Processing ✅ Design Patterns ✅ Third-Party Libraries ✅ Performance ✅ Security ✅ Functionality ✅ Feedback and Support
|
2 similar comments
|
|
Title
Implement vision chat with
ollama_chat
providerRelevant issues
Fixes #6808
Type
🆕 New Feature
Changes
ollama_chat
provider.[REQUIRED] Testing - Attach a screenshot of any new tests passing locall
If UI changes, send a screenshot/GIF of working UI fixes
Before the fix:
After the fix it works fine.
Description by Korbit AI
What change is being made?
Add functionality for handling and converting images within the
ollama_chat
module by introducing the_convert_image
function and testing this functionality with new unit tests.Why are these changes being made?
This change enhances the
ollama_chat
module by allowing it to process inline images from user messages, converting non-JPEG/PNG formats to JPEG. This feature ensures better compatibility with the image handling requirements of the ollama platform. The included unit tests confirm that the image conversion works as expected, which is essential for maintaining robustness.