Fix asyncio get_event_loop deprecation warning #9478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Fix asyncio get_event_loop() deprecation warning ### Problem The caching handler uses `asyncio.get_event_loop()` which raises a deprecation warning in Python 3.10+ and will be removed in future versions. Error: "DeprecationWarning: There is no current event loop" ### Solution Updated the code to use `asyncio.get_running_loop()` with a fallback to `asyncio.new_event_loop()` when no loop is running, which follows the recommended pattern for modern Python versions. This approach: - Avoids the deprecation warning - Creates isolated event loops when needed - Maintains the same functionality without modifying thread state - Is compatible with Python 3.10 through 3.13 ### Testing Tested on Python 3.13.x with no deprecation warnings. ### Related Issues This addresses the same issue discussed in python/cpython#93453
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
As of Python 3.11 it will throw an error to call asyncio.get_event_loop when there is no running loop in the current thread. I updated it for Python 3.13. Tested locally. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Fix asyncio get_event_loop() deprecation warning
Relevant issues
This addresses the same issue discussed in python/cpython#93453
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unit)[https://docs.litellm.ai/docs/extras/contributing_code]Tested on Python 3.13.x with no deprecation warnings.
Type
🐛 Bug Fix
Changes
Updated the code to use
asyncio.get_running_loop()with a fallback toasyncio.new_event_loop()when no loop is running, which follows the recommended pattern for modern Python versions.