Fix rtl verses to display correctly in popup and sidebar #579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te5 doesn't consistently deal correctly with comparing enums
kaseywright
approved these changes
Feb 26, 2025
…ed-in-popup-and-side-menu
elisabeth-shakespeare
deleted the
bib-880-rtl-verses-are-incorrectly-displayed-in-popup-and-side-menu
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Svelte5 doesn't consistently work when comparing enums:
sveltejs/svelte#11502
Solution" Convert them explicitly to upper-case strings first, then compare
Also looked into doing preprocess with vite for typescript, but it's already set to
script, and it doesn't work doing both. Also, syntax breaks to preprocess with onlytypescriptand notscript. I also don't think it's worth doing something that affects server-level when the solution above fixes it.