Closes #1538. Refactors 'onionservicesonly' to 'onlynet=onion', prevents bootstrapping from non-onion nodes when true, and prevents bootstrapping from any node but the trusted peer (when set) #1694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onion'. Old-style 'onionservicesonly' is deprecated but still accepted. The configuration option will be upgraded upon the first GUI settings update.
…onnect only to that trusted peer.
|
I need more time to look at it more closely, but upon first glance it looks ok, just fix the code quality issues and keep it rebased so that I can merge it when ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1538. It:
This PR does not add any warning or error dialogs, which would be useful for a user unknowingly unable to bootstrap because they set 'onlynet=onion'.
(Please ignore #1693. I accidentally hit ENTER when typing the title, which GitHub oh-so-helpfully interpreted as a click on "Create pull request".)