Check multithreading only for python plugin functions#127
Merged
FrancescAlted merged 2 commits intomainfrom Aug 1, 2023
Merged
Check multithreading only for python plugin functions#127FrancescAlted merged 2 commits intomainfrom
FrancescAlted merged 2 commits intomainfrom
Conversation
FrancescAlted
requested changes
Aug 1, 2023
Member
FrancescAlted
left a comment
FrancescAlted
left a comment
There was a problem hiding this comment.
Looks good to me. If not there yet, I'd suggest to add a couple of tests, one when using a Python codec with nthreads > 1, and other for a Python filter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lets use multithreading for user-defined plugins when the corresponding functions are not Python functions.