Repository navigation
fix: render overdue task bars verbatim on their due date instead of extending to today - #29
Merged
Merged
Conversation
…xtending to today (IT-84)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stop extending overdue task bars to
todayso overdue tasks always render verbatim ending on their actualdueDate(both at rest and during whole-bar drag previews), while preserving.bar-overduevisual indicators and overdue labels.Related Issue
Linear: IT-84
Changes
src/utils/date.ts: ExtractedcomputeBarDayRangeso tasks with astartDatealways span[startDate, dueDate]inclusive and completed/overdue tasks without astartDateanchor a compact 2-day bar ending ondueDate(clamped cleanly atchartStart).src/components/GanttRow.tsx: Replaced inline overdue-to-today stretching withcomputeBarDayRange, updatedbarStartBaseDateto anchor completed/overdue tasks withoutstartDateatdueDate, and updatedmovedPreviewso dragging an overdue task keeps its preview bar ending onmovedPreview.due.src/utils/date.test.ts&e2e/gantt.spec.ts: Added unit tests forcomputeBarDayRangeand Chrome/Firefox Playwright E2E coverage verifying verbatim overdue bar rendering, zero automatic mutations on load,.bar-overduestyling, andDetailPaneloverdue readout.Checklist
npm run format:checkpassesnpm run lintpasses (eslint . --max-warnings 0)npm run build,VITE_BACKEND=gcp npm run build, andnpm run build:serverpassnpm testpasses (24 files / 372 tests passed, 1 file / 17 Firestore emulator tests skipped)npm run test:e2epasses (24/24 across Chrome and Firefox)Verification
npm run format:check: passednpm run lint: passed (0errors,0warnings)npm run build,VITE_BACKEND=gcp npm run build,npm run build:server: passednpm test: 372 passed, 17 Firestore emulator tests skippednpm run test:e2e: 24/24 passed across Chrome and FirefoxstartDate), outgoing dependency arrow anchor atdueDate, live drag preview bounds, zero automatic mutations, and zero console/page errors in Chromium and Firefox.