Skip to content

SPI overlap support #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fiskn opened this issue Jul 12, 2017 · 5 comments
Closed

SPI overlap support #26

fiskn opened this issue Jul 12, 2017 · 5 comments

Comments

@fiskn
Copy link

fiskn commented Jul 12, 2017

It appears that SPI overlap support has recently been added to the arduino esp8266 code.

esp8266/Arduino#3189

This would be really useful for projects which are pin constrained and where the screen is only updated infrequently.

From what I can understand, due to it requiring use of the hardware CS pin, it has to use write/transferBytes functions so that all data is transmitted in one go. From looking through the code in your library, it looks to me that single byte transmissions are being used.

Do you think that your library could be modified to use overlapping SPI, or are their specific reasons why this would not be possible?

@Bodmer
Copy link
Owner

Bodmer commented Jul 15, 2017

As far as I can see, with one extra line in init() the libray should work fine in overlap mode. Single byte transactions are needed in some cases due to the need to toggle the DC line. I suspect the the need to use burst SPI transactions is only a constraint imposed by the SPI RAM chip used by the author to test the new addition. I will try out the mode later today.

@Bodmer
Copy link
Owner

Bodmer commented Jul 15, 2017

OK. I have tested the overlap mode with a ST7735 display and it works. It just needed a couple of conditional lines in init().

I will upload the change later for you to try with your display.

Bodmer added a commit that referenced this issue Jul 15, 2017
Note, must use latest ESP board package with support for the overlap
mode
@Bodmer
Copy link
Owner

Bodmer commented Jul 15, 2017

I have uploaded the changes. Post back if it does not work.

The "Setup9_ST7735_Overlap.h" setup has been used for testing.

@fiskn
Copy link
Author

fiskn commented Jul 17, 2017

Can confirm overlap SPI is working for me. Awesome work!!!

@Bodmer
Copy link
Owner

Bodmer commented Jul 17, 2017

Thanks for letting me know, good luck with your project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants