Skip to content

Conversation

@berndeplo
Copy link

@berndeplo berndeplo commented Apr 9, 2025

This pull request includes updates to dependencies in package.json and significant refactoring and enhancements to the Vue components ActionDropdown.vue and IconActionToolbar.vue.

Dependency Updates:

  • Added new dependencies: @inertiajs/inertia-vue3 and vue-router in package.json.

Refactoring and Enhancements:

  • Removed unused method openConfirmationModal from ActionDropdown.vue.
  • Cleaned up unnecessary blank lines and improved readability in the onClick and handleResponseModalConfirm methods in ActionDropdown.vue. [1] [2] [3]
  • Replaced direct URL checks with computed properties isIndexPage and isDetailPage to determine the current page type in ActionDropdown.vue. This improves the robustness of the page type detection logic.
  • Updated IconActionToolbar.vue to use a computed property for determining if the current view is a detail view, enhancing consistency and maintainability.

berndeplo added 30 commits April 8, 2025 08:48
…e resource action in ActionDropdown and tool.js
…e resource action in ActionDropdown and tool.js
@berndeplo berndeplo self-assigned this Apr 9, 2025
@berndeplo berndeplo added the enhancement New feature or request label Apr 9, 2025
@adrian-schnell
Copy link

geht damit nova 5?!

@berndeplo
Copy link
Author

Ja genau . Das war ja der Grund das ganze anzupassen, damit es auch mit Nova5 geht :-)

@berndeplo berndeplo merged commit d4686ad into main Apr 10, 2025
@berndeplo berndeplo deleted the feature/nova5Upgrade branch April 10, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants